name: app-intents-code-review
description: Reviews App Intents code for intent structure, entities, shortcuts, and parameters. Use when reviewing code with import AppIntents, @AppIntent, AppEntity, AppShortcutsProvider, or @Parameter.

App Intents Code Review

Quick Reference

Review Checklist

• [ ] perform() marked with @MainActor if accessing UI/main thread resources
• [ ] perform() completes within 30-second timeout (no heavy downloads/processing)
• [ ] Custom errors conform to CustomLocalizedStringResourceConvertible
• [ ] EntityQuery.entities(for:) handles missing identifiers gracefully
• [ ] EntityStringQuery used if Siri voice input needed (not plain EntityQuery)
• [ ] suggestedEntities() returns reasonable defaults for disambiguation
• [ ] AppShortcut phrases include .applicationName parameter
• [ ] Non-optional @Parameter has sensible defaults or uses requestValue()
• [ ] @IntentParameterDependency not used on iOS 16 targets (crashes)
• [ ] Phrases localized in AppShortcuts.strings, not Localizable.strings
• [ ] App Intents defined in app bundle, not Swift Package (pre-iOS 17)
• [ ] isDiscoverable = false for internal/widget-only intents

When to Load References

• AppIntent protocol implementation -> intent-structure.md
• Entity queries, identifiers, Spotlight -> entities.md
• App Shortcuts, phrases, discovery -> shortcuts.md
• Parameter validation, dynamic options -> parameters.md

Review Questions

1. Does perform() handle timeout limits for long-running operations?
2. Are entity queries self-contained (no @Dependency injection in Siri context)?
3. Do phrases read naturally and include the app name?
4. Are SwiftData models passed by persistentModelID, not directly?
5. Would migrating from SiriKit break existing user shortcuts?